Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML indentation guideline #622

Closed
consideRatio opened this issue Apr 1, 2018 · 4 comments
Closed

YAML indentation guideline #622

consideRatio opened this issue Apr 1, 2018 · 4 comments

Comments

@consideRatio
Copy link
Member

In the yaml templates, we are currently mixing a lot in between the following ways. I'd like to stop thinking about what I'd do myself - can we decide on a guideline to aim for?

parent1:
  - key1: value1
  - key2: value2

parent2:
- key1: value1
- key2: value2
@consideRatio consideRatio changed the title Indentation guideline YAML indentation guideline Apr 1, 2018
@consideRatio
Copy link
Member Author

It seems like the most common practice is using the parent1 kind of indentation. Going with that!

@yuvipanda
Copy link
Collaborator

yuvipanda commented Apr 2, 2018 via email

@consideRatio
Copy link
Member Author

@yuvipanda I looked at some, prometheus for example, and concluded that the tended to use the first version. I also remember some generated yaml (by chartpress i think) matched that pattern.

I'll look for linters and rules setup by kubernetes charts!

@consideRatio consideRatio mentioned this issue Apr 2, 2018
21 tasks
@consideRatio
Copy link
Member Author

@yuvipanda upon further investigation...

parent2:
- key1: value1
- key2: value2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants