Run make linkcheck in CI

[minrk]

There are quite a few broken links in our docs. We can and probably should be running make linkcheck in the docs as part of CI.

cc @willingc

Related to #723

[willingc]

Absolutely agree. Thanks @minrk.

[willingc]

Just did a make linkcheck. There are about 8 broken links and a number of redirects to new locations. I'm at Cal Poly today and will try to do a cleanup of the links and then add the linkcheck to Travis.

[choldgraf]

ah this is a great idea

[consideRatio]

❤️
It may also be good to have tools/lint.py run, it is on my long term todo list. Currently I run it manually from time to time.

[willingc]

If we run a linter, we should also start using black for Python code for style (over time).

[consideRatio]

Ah deal @willingc I'll look into that! It is currently only linting yaml and verifying it makes sense with kubernetes resource specifications.

[consideRatio]

In #758 i added tools/lint.py which i should now rename to lint-and-validate-k8s-yaml.py as part of the CI.

@willingc you seem to be in the know of how to do this, could you add a make linkcheck to the CI?

[consideRatio]

Bumping this, I'd love to see this now that we are making additional changes to the docs.

Looked at whats going on in the makefiles etc, but didn't quickly conclude what I needed to do.
https://github.com/jupyterhub/jupyterhub/blob/4d2d677777ef63f466934376d726cd6130df4a34/docs/make.bat

[choldgraf]

is this now just a matter of adding make linkcheck into one of our travis/circle builds?

[consideRatio]

Hmmm, I think it will fail without proper reason due to "missing anchor" stuff that actually works though.

If we make it make linkcheck || true then we get the info without the crash on failure. I'm not confident about the make linkcheck as part of the CI though, as it often does not happen as a consequence of a new PR's code itself but simply becoming outdated.

Seems like we should check internal references rather than external, hmmm, perhaps make linkcheck also requires us to first do make html, right?

[choldgraf]

ah I see - perhaps something to just do as a "team process" kind of thing once in a while? Or is there a way to make the anchor links pass?

[consideRatio]

@choldgraf I don't know - I did not investigate it though.

[manics]

Could you add a Travis cron job so you'll know if the master branch breaks?

[consideRatio]

Sounds great @manics !!!

[consideRatio]

We now have a linkcheck running that provide output on build, it has typically failed almost nonstop, but at the same time I've caught a lot of things thanks to it!

Thanks @manics!