Fix link to extending Jupyterhub page #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Jun 14, 2018
doc/source/setup-jupyterhub.rst
Outdated
| @@ -164,6 +164,6 @@ Install JupyterHub | |||
| entering any username and password combination will let you enter the hub. | |||
|
|
|||
| Congratulations! Now that you have JupyterHub running, you can | |||
| `extend it <extending-jupyterhub.html>`_ in many ways. You can use a pre-built | |||
| `extend it <extending-jupyterhub.rst>`_ in many ways. You can use a pre-built | |||
There was a problem hiding this comment.
The target in the built docs is html, not rst, so this change would break the link.
However, these links should be using rst refs, not file extensions, so this should be:
:ref:`extend it <extending-jupyterhub>`There appear to be several that should be fixed in this doc. Would you like to take a stab? You can run make linkcheck to verify that links resolve.
|
thanks for the fix @alanderex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.