Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to extending Jupyterhub page #723

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Fix link to extending Jupyterhub page #723

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d40ef3
Fix link to extending Jupyterhub page
alanderex Jun 13, 2018
d300249
Update setup-jupyterhub.rst
alanderex Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/setup-jupyterhub.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,6 @@ Install JupyterHub
entering any username and password combination will let you enter the hub.

Congratulations! Now that you have JupyterHub running, you can
`extend it <extending-jupyterhub.html>`_ in many ways. You can use a pre-built
`extend it <extending-jupyterhub.rst>`_ in many ways. You can use a pre-built
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target in the built docs is html, not rst, so this change would break the link.

However, these links should be using rst refs, not file extensions, so this should be:

:ref:`extend it <extending-jupyterhub>`

There appear to be several that should be fixed in this doc. Would you like to take a stab? You can run make linkcheck to verify that links resolve.

image for the user container, build your own image, configure different
authenticators, and more!