Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[need help] updating changelog for v0.8 #1114

Merged
merged 21 commits into from
Feb 7, 2019
Merged

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Jan 23, 2019

Since we are ready to release v0.8 (#1054) this PR updates the changelog for new features.

It needs help from the jupyterhub team to fill in missing pieces!. Please do this either via "suggested edits" in the GitHub UI, or by pushing directly to my branch.

I've marked areas where we need more information with "TODO".

Once we get it filled out, we can merge and get a move-on with the new version!

cc @jupyterhub/jupyterhubteam @jupyterhub/binder-team

Things I could use help with


### Breaking changes

### New Features


## [0.8.0](https://github.com/jupyterhub/zero-to-jupyterhub-k8s/compare/0.7.0..0.8.0) - [Richie Benaud](https://en.wikipedia.org/wiki/Richie_Benaud) - 2019-01-24
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have semi arbitrarily picked Richie Benaud for this one, @yuvipanda I hope that's OK!

CHANGELOG.md Show resolved Hide resolved
Co-Authored-By: choldgraf <choldgraf@gmail.com>
@manics
Copy link
Member

manics commented Jan 25, 2019

hub.extraConfig: not clear to me whether the old format is deprecated:

hub.extraConfig should be a dict of strings,
but found a single string instead.

The keys can be anything identifying the
block of extra configuration.

Try this instead:

    hub:
      extraConfig:
        myConfig: |

@consideRatio
Copy link
Member

The new format allows for multiple extraConfig entries as a dict can be merged by Helm, while a string cant.

So, let's add a deprecation note in the changelog?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@choldgraf choldgraf added this to the 0.8 milestone Jan 25, 2019
@choldgraf
Copy link
Member Author

I added a few more features using @consideRatio's excellent summary from #841. I also added the contributor list. Edits / additions / subtractions / reorgs are welcome!

@consideRatio consideRatio mentioned this pull request Jan 27, 2019
6 tasks
@minrk
Copy link
Member

minrk commented Feb 6, 2019

@consideRatio

So, let's add a deprecation note in the changelog?

There is a deprecation note in the changelog when this was deprecated (0.6). What's changed in 0.8 is that users are now notified when they use the deprecated configuration. I updated the deprecation note in the image to clarify that the config is loaded and a note in the changelog that the deprecation warnings and validation errors are a new feature.

@minrk
Copy link
Member

minrk commented Feb 6, 2019

I added a few more notes for things I found, and some upgrade and troubleshooting steps. I think we're in pretty good shape for making a beta release tomorrow.

CHANGELOG.md Outdated Show resolved Hide resolved
minrk added 7 commits February 7, 2019 10:49
this file is still not linked from anywhere
doc links should not include `.html` suffix
doc refactor removed the file from the flow, but not the file itself.
Preserve the URL, but redirect to the new target.
<https://cloud.google.com/compute/docs/machine-types>`_. See
the `preemptible node documentation
<https://cloud.google.com/compute/docs/instances/preemptible>`_ for more
information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to this, is an issue that is not yet resolved I think: jupyterhub/kubespawner#223

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, I recall that whenever a user is evicted, as they are from preemptible node pools that run out of their usage time for some reason, they will not be able to login again without a hub-pod restart.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's something we should look at for this release. Do you think this means we should not recommend looking at preemptible nodes for now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out the recommendation for now

Copy link
Member

@consideRatio consideRatio Feb 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would not recommend them until one of us have successfully utilized them with users that authenticate regularly etc. I ended up with trouble doing it.

I wrote this before I learned about these issues.

@consideRatio
Copy link
Member

@minrk this is excellent!!

This LGTM!

@minrk
Copy link
Member

minrk commented Feb 7, 2019

OK! Let's hit the button and make the beta. This PR updates the version in the docs to install the beta, so just building and publishing the tag should do it.

@minrk minrk merged commit 0ed0304 into jupyterhub:master Feb 7, 2019
@minrk
Copy link
Member

minrk commented Feb 7, 2019

ok, published 0.8.0-beta.1 (I forgot that helm doesn't accept Python semver-style 0.8.0b1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants