Add hub.loadRoles configuration #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/add-hub.loadRoles
branch
5 times, most recently
from
13474af
to
264a1a6
Compare
This was referenced Sep 27, 2021
Closed
manics
reviewed
Sep 27, 2021
The motivation for adding a dedicated chart configuration is that hub.config.JupyterHub.load_roles would end up being overridden easily if configured from multiple config files. So, having a dictionary configuration for the same thing can help.
consideRatio
force-pushed
the
pr/add-hub.loadRoles
branch
4 times, most recently
from
571ec8d
to
3ff3f7a
Compare
consideRatio
force-pushed
the
pr/add-hub.loadRoles
branch
from
3ff3f7a
to
56989a6
Compare
manics
reviewed
Sep 30, 2021
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
|
Thank you for your review efforts @manics! ❤️ 🎉 |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Oct 2, 2021
jupyterhub/zero-to-jupyterhub-k8s#2405 Merge pull request #2405 from consideRatio/pr/add-hub.loadRoles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for adding a dedicated chart configuration is that
hub.config.JupyterHub.load_roles would end up being overridden easily if
configured from multiple config files. So, having a dictionary
configuration for the same thing can help.
An example for when this would be relevant is the BinderHub helm chart. It defines a hub.service and will want to define a hub.loadRole as well. But then what happens if a user wants to configure the BinderHub Helm chart? The user will end up having overridden BinderHub's config of the JupyterHub Helm chart.
I've deliberated a while on this, and some comments are made in #2386 about it.