Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill image tags values.yaml with placeholders #541

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 26, 2018

these values (both name and tag) are autogenerated by chartpress, so the values stores in values.yaml will never be used.

We could also replace these with an empty dict, so that it's extra clear that the image data needs to be filled out by running chartpress, and the values.yaml tracked by the repo is never valid.

cc @consideRatio who I think may have run into an issue related to this.

these values (both name and tag) are autogenerated by chartpress, so the values stores in values.yaml will never be used.

We could also replace these with an empty dict.
Copy link
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minrk.

@yuvipanda yuvipanda merged commit 53a957d into jupyterhub:master Feb 26, 2018
@consideRatio
Copy link
Member

Ah... Thanks @minrk !

@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants