clarify recommendation for community nginx ingress controller #547
Conversation
doc/source/advanced.md
Outdated
|
|
||
| 1. Make sure that DNS is properly set up (varies wildly depending on the ingress | ||
| 1. Make sure that DNS is properly set up (this may vary wildly depending on the ingress |
There was a problem hiding this comment.
This sentence feels a bit strange to me (the "depending on the ingress controller you are using" part) given that just above we've said that you can only use one of two possible ingress controllers
There was a problem hiding this comment.
ah, so kube-lego only works with the nginx and gclb ingress controller. So you can use any ingress controller you want, but if you want automatic HTTPs with kube-lego then you can only use these two controllers for now.
There was a problem hiding this comment.
The situation is getting better with https://github.com/jetstack/cert-manager, but I've never used that yet.
|
one small comment, than that it looks good! |
|
You can use any ingress controller you want, we just recommend this
particular one, since we have experience with it (although the experience
has not been the greatest!)
…On Fri, Mar 2, 2018 at 10:22 AM, Chris Holdgraf ***@***.***> wrote:
one small comment, than that it looks good!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#547 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB23vdJDmNS8QQIYOBLBi76mQ6m0HiYks5taY3zgaJpZM4SXT4y>
.
--
Yuvi Panda T
http://yuvi.in/blog
|
|
Though the text currently says "This approach currently only works with the community maintained nginx ingress controller and...", which is where my confusion comes from :-) |
|
Edits made @choldgraf @yuvipanda. Hopefully, it makes it a bit clearer. |
|
thanks @willingc !!! |
Based on discussion with @yuvipanda on Gitter. This PR provides a specific link to the community maintained nginx ingress controller.