Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make daemonsets do a rolling update #570

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Make daemonsets do a rolling update #570

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a73a6c9
Make daemonsets do a rolling update
yuvipanda Mar 8, 2018
ab95bfe
Use 100% instead of large number for image puller rolling update
yuvipanda Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jupyterhub/templates/image-puller/_helper.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ spec:
component: {{ .name }}
release: {{ .top.Release.Name }}
heritage: {{ .top.Release.Service }}
updateStrategy:
type: RollingUpdate
rollingUpdate:
# Arbitrarily large number, since we want all the old daemonsets to die immediately
# and new ones to be born
maxUnavailable: 1000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can set this to be 100% instead I think:
https://v1-8.docs.kubernetes.io/docs/api-reference/v1.8/#rollingupdatedaemonset-v1beta2-apps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @consideRatio! fixed.

template:
metadata:
labels:
Expand Down