Add property to control debug logging #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
reviewed
Mar 22, 2018
jupyterhub/values.yaml
Outdated
| @@ -204,3 +204,6 @@ cull: | |||
| users: false | |||
| timeout: 3600 | |||
| every: 600 | |||
|
|
|||
| debug: | |||
| enabled: false | |||
There was a problem hiding this comment.
Is there a reason for this to be debug.enabled instead of just debug: false?
There was a problem hiding this comment.
I copied the style used for rbac.enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #589
If
debug.enabledthis turns on debug logging for JupyterHub, Spawner, and the included nginx ingress container. configurable-http-proxy is unchanged since it's already at debug (though should it default to info instead?)