Add nodePort option helm chart for hub

[summerswallow]

The hub section of the helm chart permits the assigning of type to the Service for hub. By default this is ClusterIP. However, it may be desirable for the hub to be exposed so that an external load balancer can be used. Overriding the type to "NodePort" through a config.yaml file does work. However, without the ability to configure the nodePort specifically Kubernetes selects a random port between 30000 and 32767. For an external load balancer it is desirable to keep this port fixed.

[summerswallow]

If I didn't do this correctly feel free to correct it. I tarred the helm chart seems to do what I intended.

[consideRatio]

Currently values.yaml only contains:

hub:
  service:
    type: ClusterIP

Perhaps you can add a default value for hub.service.ports.nodePort ?

I think that is also why travis is currently failing

Error: render error in "jupyterhub/templates/hub/service.yaml": template: jupyterhub/templates/hub/service.yaml:16:19: executing "jupyterhub/templates/hub/service.yaml" at <.Values.hub.service....>: can't evaluate field nodePort in type interface {}

Update 1

This is how the proxy values looks, there are keys but not values for stuff, something like that should do it!

proxy:
  secretToken: ''
  service:
    type: LoadBalancer
    labels: {}
    annotations: {}
    nodePorts:
      http:
      https:
  chp:
  # ...

[summerswallow]

I've added the requested change. I originally had this in there, but tried it without and thought it worked. Well, let's see if this does the trick

[consideRatio]

@summerswallow build success! 🎉

[summerswallow]

Since the service type is allowed to be changed, adding the nodePort option is still a good idea. However, for the purposes stated above, the better approach is to change public-proxy to NodePort from LoadBalancer. The templates are set to allow that to be perfectly configurable.

[minrk]

Thanks @summerswallow!