Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{# comments #} replaced with # comments #618

Merged
merged 2 commits into from
Apr 1, 2018
Merged

{# comments #} replaced with # comments #618

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e868c
Comments {# #} replaced with #
consideRatio Apr 1, 2018
9311811
adjusted to {{\* *\}} syntax
consideRatio Apr 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jupyterhub/templates/hub/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ spec:
key: proxy.token
{{ if .Values.hub.extraEnv -}}
{{ $extraEnvType := typeOf .Values.hub.extraEnv -}}
{# If we have a list, embed that here directly. This allows for complex configuration from configmap, downward API, etc #}
{{/* If we have a list, embed that here directly. This allows for complex configuration from configmap, downward API, etc. */}}
{{ if eq $extraEnvType "[]interface {}" -}}
{{ toYaml .Values.hub.extraEnv | indent 8 }}
{{ else if eq $extraEnvType "map[string]interface {}" -}}
{# If we have a map, treat those as key-value pairs #}
{{/* If we have a map, treat those as key-value pairs. */}}
{{ range $key, $value := .Values.hub.extraEnv }}
- name: {{ $key | quote }}
value: {{ $value | quote }}
Expand Down