Chart.yaml - icon + kube & helm versions #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
|
consideRatio
force-pushed
the
chart-yaml-pr
branch
from
0b625f2 to
e55822f
Compare
consideRatio
added a commit
to consideRatio/zero-to-jupyterhub-k8s
that referenced
this pull request
Apr 2, 2018
Making Chart.yaml conform to `helm lint` by adding an icon, and declaring required k8s and helm versions.
consideRatio
changed the title
Making Chart.yaml conform to `helm lint` by adding an icon, and declaring required k8s and helm versions.
consideRatio
force-pushed
the
chart-yaml-pr
branch
from
e55822f to
09535ff
Compare
yuvipanda
requested changes
Apr 2, 2018
jupyterhub/Chart.yaml
Outdated
| home: https://zero-to-jupyterhub.readthedocs.io | ||
| sources: | ||
| - https://github.com/jupyterhub/zero-to-jupyterhub-k8s | ||
| icon: http://jupyter.org/assets/hublogo.svg |
There was a problem hiding this comment.
Can you make this https?
jupyterhub/Chart.yaml
Outdated
| name: jupyterhub | ||
| version: v0.7-dev | ||
| appVersion: v0.8.1 | ||
| description: Multi-user Jupyter installation | ||
| home: https://zero-to-jupyterhub.readthedocs.io |
There was a problem hiding this comment.
can this be https://z2jh.jupyter.org instead?
yuvipanda
approved these changes
Apr 2, 2018
|
Awesome! Thanks for the PR :) What do you think of adding |
|
@yuvipanda thanks for input and merge! :D @yuvipanda yes makes sense, also adding yamllint with a config similar to kubernetes/charts --- thats what they do I think. See #625 and in-page search for yamllint! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
helm linton the chart successfully, but was warned about a missing icon. This PR adds that icon.PR based on reading up on what to be included in Chart.yaml according to Helm and according to kubernetes/charts repo as well as by looking at charts published in kubernetes/charts.
I added required kubeVersion and tillerVersion to be 1.8+ (k8s daemonset API) and 2.7+ (helm delete annotations). See #502 for more details. Having Helm (tiller) 2.8.2 would avoid issues like described in #620 - but is not essential.