pod.status.start_time can be None #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the pod hasn’t started yet
|
@minrk this looks good to me, and I'm very confident that this not cause issues if I'd press merge so here goes! My internal voice:
|
I think if you aren't sure you can comment that it looks good to you and invite someone else to take a look as well. Otherwise mostly one person seems to be enough for small things. For bigger things maybe give people time to look at it and comment. |
|
@betatim sounds great! Thank you for giving me input on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the pod hasn’t started yet
closes jupyterhub/binderhub#510