-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for OpenShift #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this, @willingc!
The linked document (https://github.com/jupyter-on-openshift/jupyterhub-quickstart/blob/master/README.md) for OpenShift is an entirely different deployment method that doesn't use any of the components in this repo (the helm chart and friends). It feels similar to KubeFlow - they use some of our components (kubespawner) but nothing more. IMO, we should link to these in a 'other approaches' section or something like that, rather than 'Step 0' - since our Step 1 will not work with this Step 0.
You can use helm with OpenShift (for example, https://blog.openshift.com/getting-started-helm-openshift/). IMO, we should have instructions for that to satisfy #177.
I also feel awkward about including minishift instructions. They'll probably go out of date quickly, and we don't include minikube instructions either.
I've removed the minishift instructions since it was an FYI vs. leaving on my drive and wasn't linked in the table of contents. While I agree that longer term, we should have openshift and Helm instructions; I believe that we should offer our users the implementation that is currently least friction for folks wanting to use OpenShift. It should be clear from the Step Zero text for OpenShift that no Step 1 is required at the moment. If you wish we can bold or highlight that. |
Thanks, @willingc.
I agree on wanting to provide users of OpenShift a least friction setup. I
would like us to be very clear that it is 'set up JupyterHub on OpenShift',
rather than 'use this guide on OpenShift', since none of the things in this
guide would apply to using the other set of instructions.
Other than that, I'd like to propose a Thursday deadline for myself to get
working OpenShift + helm instructions. If not, we can merge a version of
this that clarifies based on my previous paragraph.
…On Tue, Apr 3, 2018 at 1:33 PM, Carol Willing ***@***.***> wrote:
I've removed the minishift instructions since it was an FYI vs. leaving on
my drive and wasn't linked in the table of contents.
While I agree that longer term, we should have openshift and Helm
instructions; I believe that we should offer our users the implementation
that is currently least friction for folks wanting to use OpenShift.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#634 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB23nJLU-rtpfY7vZBSer7dO-SnPzxKks5tk9y1gaJpZM4TFsvd>
.
--
Yuvi Panda T
http://yuvi.in/blog
|
After some playing around, it looks like Helm on OpenShift is very poorly supported. I made a PR to this PR in willingc#1 to clarify that JupyterHub on OpenShift is a completely different project that OpenShift users can use, and the rest of this guide does not apply. |
Clarify that JupyterHub on OpenShift is a different project
Close #177