Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for OpenShift #634

Merged
merged 7 commits into from
Apr 6, 2018

Conversation

willingc
Copy link
Collaborator

@willingc willingc commented Apr 3, 2018

Close #177

  • Add section on OpenShift and references to the OpenShift repo which simplifies installation.
  • Add minishift document for development but do not link to any table of contents

Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, @willingc!

The linked document (https://github.com/jupyter-on-openshift/jupyterhub-quickstart/blob/master/README.md) for OpenShift is an entirely different deployment method that doesn't use any of the components in this repo (the helm chart and friends). It feels similar to KubeFlow - they use some of our components (kubespawner) but nothing more. IMO, we should link to these in a 'other approaches' section or something like that, rather than 'Step 0' - since our Step 1 will not work with this Step 0.

You can use helm with OpenShift (for example, https://blog.openshift.com/getting-started-helm-openshift/). IMO, we should have instructions for that to satisfy #177.

I also feel awkward about including minishift instructions. They'll probably go out of date quickly, and we don't include minikube instructions either.

@willingc
Copy link
Collaborator Author

willingc commented Apr 3, 2018

I've removed the minishift instructions since it was an FYI vs. leaving on my drive and wasn't linked in the table of contents.

While I agree that longer term, we should have openshift and Helm instructions; I believe that we should offer our users the implementation that is currently least friction for folks wanting to use OpenShift.

It should be clear from the Step Zero text for OpenShift that no Step 1 is required at the moment. If you wish we can bold or highlight that.

@yuvipanda
Copy link
Collaborator

yuvipanda commented Apr 3, 2018 via email

@yuvipanda
Copy link
Collaborator

After some playing around, it looks like Helm on OpenShift is very poorly supported. I made a PR to this PR in willingc#1 to clarify that JupyterHub on OpenShift is a completely different project that OpenShift users can use, and the rest of this guide does not apply.

yuvipanda and others added 2 commits April 3, 2018 22:28
Clarify that JupyterHub on OpenShift is a different project
@willingc willingc dismissed yuvipanda’s stale review April 6, 2018 10:12

incorporated yuvi's changes

@willingc willingc merged commit 6e80c04 into jupyterhub:master Apr 6, 2018
@willingc willingc deleted the update-openshift branch April 6, 2018 10:12
@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants