import updated culler #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use semaphore to limit Hub API activity, which may improve hub performance with lots of culling (e.g. mybinder.org) - supports max-age culling (with jupyterhub 0.9), which will allow us to deprecate the podCuller image when we bump jupyterhub
requires jupyterhub 0.9
|
Could there be someone who is surprised (stuff breaks suddenly) by these changes? Otherwise: merge, as this is a copy of what is in jhub. |
|
Culler should be its own package now, IMO :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from jupyterhub/jupyterhub#1779