Support LDAP login (LDAPAuthenticator) #649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #264
Based on https://github.com/jupyterhub/ldapauthenticator/blob/1bb93f3ad258fdcc464c5e5c88f36005ae579ce0/README.md
I've tried to follow the general pattern in
jupyterhub_config.py
when naming LDAP parameters but not everything is clear to me.LDAPAuthenticator seems to have many more parameters than the other auth providers, so I added a new function
set_config_if_not_none
in z2jh.py to make it easier to keep the built-in defaults from LDAPAuthenticator when a value isn't overridden.I've only tested this with my own setup:
Warning: I have not tested the other parameters, in particular the active directory setup from https://github.com/jupyterhub/ldapauthenticator/blob/1bb93f3ad258fdcc464c5e5c88f36005ae579ce0/README.md#active-directory-integration is untested by me.