Tighten up hook-image-puller's image-awaiter jobs requested RBAC permissions #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new image-awaiter used in conjunction with the hook-image-puller does not need a ClusterRoleBinding as it will no longer inspect the nodes in the cluster, but instead inspect the DaemonSets within the namespace.
|
this seems reasonable to me! though will hold off on merging some someone with a bit more k8s expertise than I |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
image-awaiterjob used in conjunction with thehook-image-pullerdoes not need aClusterRoleand aClusterRoleBindingas it will no longer inspect the nodes in the cluster, but instead simply inspect aDaemonSetwithin the current namespace. This PR simply replacesClusterRolewithRole, andClusterRoleBindingwithRoleBinding.