Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call the hub container 'hub' #695

Merged
merged 1 commit into from
May 25, 2018
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented May 24, 2018

hub-container container is redundant

hub-container container is redundant
@consideRatio
Copy link
Member

=D I've also considered adding or not adding of say "-container" or "-config" or "-secret" to the names of various k8s resources, in #625.

Would you recommend we systematically avoid adding the resource type to the name? It is the most common practice within z2jh currently, but it is not systematic. The downside for the change, is that it might affect something that I don't figure out it might affect in all circumstances, so I've been cautious to do it systematically.

In this case, I cant imagine there will be a problem as the container name isn't referenced anywhere within z2jh afaik, but if we change for example "hub-config" to "hub" we might need to update some documentation and people might have prewritten snippets with kubectl referencing "hub-config" etc, I guess the point of my caution for that is that I don't fully know.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to change as far as I know.

@betatim betatim merged commit c5ec562 into jupyterhub:master May 25, 2018
@betatim
Copy link
Member

betatim commented May 25, 2018

People who use hub-container containers also have PIN numbers :D

@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants