Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be JUPYTERHUB_CRYPT_KEY #764

Merged
merged 2 commits into from
Jul 16, 2018
Merged

Conversation

elgalu
Copy link
Contributor

@elgalu elgalu commented Jul 15, 2018

Should be JUPYTERHUB_CRYPT_KEY not Should be JUPYTERHUB_CRYPTO_KEY
@consideRatio
Copy link
Member

consideRatio commented Jul 15, 2018

@elgalu Woooo this caused me confusion before but I never grasped the issue clearly.

Overview

  1. values.yaml contains the auth.state.cryptoKey entry
  2. schema.yaml validates this entry and has misleading documentation written about it
  3. secret.yaml (named: hub-secret) saves this value in it as auth.state.crypto-key
  4. deployment.yaml (named: hub) reads the secret value and provides it to the hub pod as an environment variable named JUPYTERHUB_CRYPT_KEY
  5. JupyterHub utilize this key without additional configuration.

Conclusion

I think the statement in schema.yaml should be updated in the way you suggest! I'd also want to make it clear that the value provided in values.yaml will be used to set the environment variable and not the other way around. I added a commit to do this, does it look good to you @elgalu ?

@elgalu
Copy link
Contributor Author

elgalu commented Jul 16, 2018

👍

@consideRatio consideRatio merged commit 0019342 into jupyterhub:master Jul 16, 2018
@consideRatio
Copy link
Member

Wieeee thank you for the PR! :D

@elgalu elgalu deleted the patch-1 branch July 16, 2018 12:06
@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants