Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure image puller works with long repo names #768

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

clkao
Copy link
Contributor

@clkao clkao commented Jul 18, 2018

Currently this fails since container should be alphanum.

prePuller:
  extraImages:
    cpu:
      name: custom.registry-server/repo/image
      tag: latest

@consideRatio
Copy link
Member

Excellent solution and catch @clkao!! ❤️

@consideRatio consideRatio merged commit f35695a into jupyterhub:master Jul 18, 2018
@manics manics mentioned this pull request Aug 15, 2018
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants