Ensure url correctness #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure url correctness in jupyterhub_config.py of cull configuration using url_path_join. Function url_path_join define in z2jh.py.
minrk
reviewed
Jul 26, 2018
There was a problem hiding this comment.
Following jupyterhub/jupyterhub#2008 if we require JupyterHub 0.9.1 (what we currently use by default now), then the fix ought to be removing the --url arg altogether, because the kubernetes bug it was a workaround for should no longer be relevant.
| @@ -255,7 +255,7 @@ def generate_user_name(spawner): | |||
| '--timeout=%s' % cull_timeout, | |||
| '--cull-every=%s' % cull_every, | |||
| '--concurrency=%s' % cull_concurrency, | |||
| '--url=http://127.0.0.1:8081' + c.JupyterHub.base_url + 'hub/api', | |||
| '--url=http://127.0.0.1:8081' + url_path_join(c.JupyterHub.base_url, 'hub/api'), | |||
There was a problem hiding this comment.
url_path_join is already defined in jupyterhub.utils, so we can import it from there.
There was a problem hiding this comment.
change it, thanks for your review!
Remove url_path_join in z2jh.py, it's already defined in jupyterhub.utils.
|
Wieeee! :D Thank you for the PR @chaoleili and the review @minrk ! ❤️ |
|
wooo thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure url correctness in jupyterhub_config.py of cull configuration
using url_path_join. Function url_path_join define in z2jh.py.