Change travis setup to only deploy once #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SInce adding a build matrix testing several kubernetes versions we are deploying twice, once for each kube version. This changes our deploy setup so it only deploys once.
|
@betatim Thank you sorry for causing some headache! From this travis documentation it seems like we could solve this if we do... deploy:
provider: script
skip_cleanup: true
script: ./ci/deploy.sh
on:
branch:
- master
- v0.7-dev
condition: "$KUBE_VERSION = 1.9.4" |
|
Yikes... Perhaps I can blame the jetlag I'm having, I thought you simply reduced the env-matrix to one version but you are attempting to do the same thing i suggested but in a much nicer way. Let's try it! |
|
@betatim from https://travis-ci.org/jupyterhub/zero-to-jupyterhub-k8s/builds/407953966 it seems that deploy.sh still is run for both 1.10 or 1.9.4. Attempting the solution from the travis documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #762
Since adding a build matrix testing several kubernetes versions we are
deploying twice, once for each kube version. This changes our deploy
setup so it only deploys once.