-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying image pull secret #801
Changes from 9 commits
27d243f
f3e0da1
bb6612a
0088fd6
241e78c
b0da471
1412641
72d201f
a94dd0d
cbc53aa
fead3a8
ffe59fa
84d295d
1724563
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{{- if .Values.singleuser.image.pullSecret }} | ||
kind: Secret | ||
apiVersion: v1 | ||
metadata: | ||
name: singleuser-image-credentials | ||
labels: | ||
{{- $_ := merge (dict "componentSuffix" "-image-credentials") . }} | ||
{{- include "jupyterhub.labels" $_ | nindent 4 }} | ||
type: kubernetes.io/dockerconfigjson | ||
data: | ||
.dockerconfigjson: {{ template "singleuser.image.pullSecret" . }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looking great! Helm is silly, they have two functions doing the same thing: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hehe ill update! |
||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh thinking about it, let us not propagate this mistake in KubeSpawner but instead try to alleviate it by calling this
image-pull-secret-name
instead.