Improved template linting/validation and CI-integration #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
lint-and-validate-ci
branch
4 times, most recently
from
aa00612 to
7490567
Compare
Previously when chartpress generated output to values.yaml, it could turn `"strings"` to `'strings'` and `null` to nothing.
When two sources of values, like the charts defaults in values.yaml and those provided by the user in config.yaml merged a dict from config.yaml with a field that was blank in values.yaml a warning was given. No more of that now.
consideRatio
force-pushed
the
lint-and-validate-ci
branch
from
7490567 to
bb765d7
Compare
This was referenced Aug 14, 2018
Closed
|
Really nice! Is this something we could document in the devdocs somewhere? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test that can be run locally and with the CI, even before chartpress is used to build images and the chart.
tools/templates/lint-and-validate.yamlhelm linthelm templateyamllintkubeval