cull.maxAge ignored bugfix #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config entry cull.maxAge was previously never consumed by the jupyterhub_config.py as it reads from its configmap where the entry cull.max-age was never set. This affected maxAge based cullings on JupyterHub 0.9+.
20 tasks
|
Lets go all out @betatim, 50 is way to high! How about 1 line? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config entry cull.maxAge was previously never consumed by the
jupyterhub_config.py as it reads from its configmap where the entry
cull.max-age was never set. This affected maxAge based cullings on
JupyterHub 0.9+ to never cull due to exceeding a set maxAge.