[Part 1 of #758] Remove pod-culler remnants #890
Conversation
| @@ -18,5 +18,3 @@ charts: | |||
| valuesPath: singleuser.image | |||
| buildArgs: | |||
| JUPYTERHUB_VERSION: 0.9.2 | |||
| pod-culler: | |||
| valuesPath: cull.podCuller.image | |||
There was a problem hiding this comment.
No longer building the image, should be very safe.
| {{ include "jupyterhub.matchLabels" $_ | replace ": " "=" | replace "\n" "," | quote }} | ||
| {{- end }} | ||
|
|
||
|
|
There was a problem hiding this comment.
This helper was only used by the deleted pod-culler deployment
There was a problem hiding this comment.
The service running in the hub pod will now take care of the culling, and the hub pod has the credentials required do to so already.
| cull_max_age = get_config('cull.max-age') | ||
| if cull_max_age and V(jupyterhub.__version__) >= V('0.9'): | ||
| if cull_max_age: |
There was a problem hiding this comment.
This will have the same truth table no matter what, if we assume jupyterhub.version to always be >= 0.9, which we do.
| name: pod-culler | ||
| labels: | ||
| {{- include "jupyterhub.labels" . | nindent 4 }} | ||
| --- |
There was a problem hiding this comment.
This serviceAccount, and associated role bound to it, was only used by the pod-culler deployment.
| @@ -1,39 +0,0 @@ | |||
| {{- if and .Values.cull.enabled .Values.cull.maxAge -}} | |||
| podCuller: | ||
| image: | ||
| name: jupyterhub/k8s-pod-culler | ||
| tag: generated-by-chartpress |
There was a problem hiding this comment.
These values were only consumed by the deleted deployment.
As of JupyterHub 0.9, we ended up with some dead code no longer in use.