[Part 9 of #758] Preset: scheduling.nodeAffinity.matchNodePurpose
#927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is very bugged... Apparently everything is up to date even though i try force push crap content. Also, the commits have a different order than they should have. |
All good then! Just make sure to ignore the commit order as viewed in GitHub. |
20 tasks
consideRatio
force-pushed
the
758-9-match-node-purpose
branch
from
61ea865 to
413154b
Compare
Extra storage labels are now configurable through config.yaml and `singleuser.storageExtraLabels`.
consideRatio
force-pushed
the
758-9-match-node-purpose
branch
from
413154b to
44c3c74
Compare
<core|user> pods now get `tolerations` for the node taint `hub.jupyter.org/dedicated=<user|core>:NoSchedule` that could optionally be added to nodes or all nodes in a node group (aka. node pool). Note that due to a bug with using the `gcloud` CLI, we also add the toleration for the same taint where `/` is replaced with `_`. In this commit, `singleuser.extraTolerations` are now also made configurable allowing you to add your own custom tolerations to the user pods.
These affinities allow for more fine grained control of where a pod will schedule.
consideRatio
force-pushed
the
758-9-match-node-purpose
branch
from
44c3c74 to
972af40
Compare
Sieboldianus
added a commit
to Sieboldianus/zero-to-jupyterhub-k8s
that referenced
this pull request
Aug 3, 2022
Originally `--enable-vmss`, changed to `--vm-set-type`, see [jupyterhub#927](927) 927: Azure/azure-cli-extensions#927 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review
scheduling.nodeAffinity.matchNodePurposeAbout
This preset makes pods of
user | corekind eitherpreferrequireorignorea scheduling on a node with a matching label forhub.jupyter.org/node-purpose: user | core.