[Part 11 of #758] Added scheduling.userPlaceholder
#929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
minrk
reviewed
Sep 12, 2018
jupyterhub/templates/_helpers.tpl
Outdated
| {{- /* | ||
| A custom resource request. | ||
| */}} | ||
| {{- define "jupyterhub.resources" -}} |
There was a problem hiding this comment.
I think this is a helpful rule of thumb: never make a helper that's only used once. This appears to only be used in one place. Even if you think it might be used elsewhere, the time to refactor is when you want to reuse it, not before.
There was a problem hiding this comment.
👍
It will be used in the user-dummy as well. Needing to make these helpers have made me cringe in general. I wonder if k-sonnet allows for better handling of combining dict values provided by the user than helm.
consideRatio
force-pushed
the
758-11-user-placeholder
branch
2 times, most recently
from
b1df768 to
208bcf1
Compare
consideRatio
commented
Sep 17, 2018
jupyterhub/templates/_helpers.tpl
Outdated
|
|
||
| {{- if and $r $l }} | ||
| {{- println }} | ||
| {{- end }} |
There was a problem hiding this comment.
It is valid, so lets not make the stuff more complicated, i think.
There was a problem hiding this comment.
This is now removed in the added commit to this PR.
Extra storage labels are now configurable through config.yaml and `singleuser.storageExtraLabels`.
consideRatio
force-pushed
the
758-11-user-placeholder
branch
from
208bcf1 to
57a6069
Compare
<core|user> pods now get `tolerations` for the node taint `hub.jupyter.org/dedicated=<user|core>:NoSchedule` that could optionally be added to nodes or all nodes in a node group (aka. node pool). Note that due to a bug with using the `gcloud` CLI, we also add the toleration for the same taint where `/` is replaced with `_`. In this commit, `singleuser.extraTolerations` are now also made configurable allowing you to add your own custom tolerations to the user pods.
These affinities allow for more fine grained control of where a pod will schedule.
consideRatio
force-pushed
the
758-11-user-placeholder
branch
from
57a6069 to
79a6e28
Compare
Read about them in schema.yaml
consideRatio
force-pushed
the
758-11-user-placeholder
branch
from
79a6e28 to
ef102f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review
scheduling.userPlaceholderoptionAbout
Read about them in schema.yaml please, whats written here propagates to the configuration reference in the guide.