Skip to content

Use toolbar registry for the deck button and move it to the right #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jan 14, 2025

Checklist

  • ran doit lint locally

References

Fixes #17

image

Code changes

  • use the settings to add the deck button to the notebook toolbar
  • move the button to the right side of the toolbar

Note

The settings cannot be used for markdown files because the toolbar registry seems to be the same for other file types.

User-facing changes

Button moved on le right of the toolbar.

Backwards-incompatible changes

None

@brichet brichet added the enhancement New feature or request label Jan 14, 2025
@brichet brichet requested a review from jtpio January 14, 2025 10:57
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good place to put it 👍

Thanks!

@jtpio jtpio merged commit 49644b8 into jupyterlab-contrib:main Jan 14, 2025
1 check passed
@brichet brichet deleted the deck_button branch January 14, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The toolbar button to open the slideshow is not located to the right of the notebook toolbar
2 participants