-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrolling on g g
and G
#137
Fix scrolling on g g
and G
#137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried out the binder. gg
and G
working as expected, jumping to top/bottom cell respectively and the view jumps, too, i.e. the scrolling seems to be working now. Thanks for the speedy fix @krassowski!
This does indeed fix the scrolling but I think it's doing something weird to selection state of the cell. When i do this I have to hit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to figure out the best way to get us into jupyter-command-mode with the scrolled to cell one enter press away from being in edit mode. I have one suggestion i added to the review but im not sure it's the best way. I wish there was an option in scrollToCell
that allowed you choose whether to enter edit mode.
Co-authored-by: ianhi <ianhi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick follow up fixes @krassowski !
Closes #134
To add more context, we should make this change anyways, because otherwise scrolling would not work in the
full
windowing mode.