-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebind Esc to "Leave Current Mode" #70
Rebind Esc to "Leave Current Mode" #70
Conversation
561a5c0
to
6838ee5
Compare
I've uploaded a build to anaconda under |
We will need to resolve conflicts here and possibly some more discussion. @ianhi do you have an opinion on this one? |
I think this is a very nice idea! It would also go a long way towards helping out with #73 |
@asford do you have time to resolve the merge conflicts - or would you prefer someone else resolve them and push? |
Please grab the conn on the merge. |
Not sure why this got autoclosed - and I seem unable to re-open it. very confusing. |
I wonder if inability to re-open the PR has something to do with deforking. It seems like the branch in the PR was forked from jwkvam's repo. |
This is an optional add-on to #69 that makes "Leave Current Mode" the default binding for Esc.
The leave-current-mode behavior of "Esc" could/should be made default for this plugin.
Though this is a shift in behavior for existing jupyterlab-vim users, it's less disruptive for existing jupyterlab users.
Please finish the following when submitting a pull request:
History.md
briefly documenting the change.If this is a release, additionally do the following:
package.json
jlpm install
to updateyarn.lock
Thanks!