Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebind Esc to "Leave Current Mode" #70

Closed

Conversation

asford
Copy link
Contributor

@asford asford commented Oct 1, 2022

This is an optional add-on to #69 that makes "Leave Current Mode" the default binding for Esc.

The leave-current-mode behavior of "Esc" could/should be made default for this plugin.
Though this is a shift in behavior for existing jupyterlab-vim users, it's less disruptive for existing jupyterlab users.

Please finish the following when submitting a pull request:

  • Add a line to History.md briefly documenting the change.

If this is a release, additionally do the following:

  • Update the dependencies in package.json
  • Run jlpm install to update yarn.lock

Thanks!

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Binder 👈 Launch a binder notebook on branch asford/jupyterlab-vim/leave_current_mode_default

@asford asford force-pushed the leave_current_mode_default branch from 561a5c0 to 6838ee5 Compare October 1, 2022 19:47
@asford
Copy link
Contributor Author

asford commented Oct 1, 2022

I've uploaded a build to anaconda under jupterlab_vim=0.15.1+leave_current_mode,
as I wasn't able to get the binding demo functioning particularly well.

asford added a commit to asford/jupyterlab_vim-feedstock that referenced this pull request Oct 1, 2022
@krassowski
Copy link
Collaborator

We will need to resolve conflicts here and possibly some more discussion. @ianhi do you have an opinion on this one?

@ianhi
Copy link
Collaborator

ianhi commented Jun 16, 2023

I think this is a very nice idea! It would also go a long way towards helping out with #73

@ianhi
Copy link
Collaborator

ianhi commented Jun 16, 2023

@asford do you have time to resolve the merge conflicts - or would you prefer someone else resolve them and push?

@asford
Copy link
Contributor Author

asford commented Jun 19, 2023

Please grab the conn on the merge.
I'm no longer able to drive this PR.

@ianhi ianhi closed this Jul 31, 2023
@ianhi ianhi reopened this Aug 1, 2023
@ianhi ianhi closed this Aug 1, 2023
@ianhi ianhi reopened this Aug 1, 2023
@ianhi ianhi closed this Aug 1, 2023
@ianhi
Copy link
Collaborator

ianhi commented Aug 1, 2023

Not sure why this got autoclosed - and I seem unable to re-open it. very confusing.

@krassowski krassowski reopened this Aug 1, 2023
@krassowski krassowski closed this Aug 1, 2023
@firai
Copy link
Collaborator

firai commented Aug 3, 2023

I wonder if inability to re-open the PR has something to do with deforking. It seems like the branch in the PR was forked from jwkvam's repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants