Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows, build against JupyterLab 4, fix build TS 5 errors, lint #346

Merged
merged 19 commits into from
Jul 15, 2024

Conversation

krassowski
Copy link
Contributor

@krassowski krassowski commented Jul 14, 2024

Follow-up to jupyterlab-contrib/jupyterlab-contrib.github.io#74

  • Aligns workflows with latest template (except for using master and using an older version of publishing workflows because I think we do not have a bot app setup here)
  • Migrates to yarn3 lockfile
  • Updates dependencies for JupyterLab 4 so that the extension can be easily built using a supported JupyterLab version
  • Fixes linting errors @ts-ignore improving compatibility with less common but valid notebooks
  • Fixes build error for new TypeScript version (errors are now unknown)

@krassowski
Copy link
Contributor Author

Check release is failing because releaser does not know what to do with pip-deepfreeze:

[tool.hatch.envs.default]
type = "pip-deepfreeze"
features = ["dev", "test"]

@krassowski krassowski marked this pull request as ready for review July 14, 2024 10:22
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @krassowski

we do not have a bot app setup here

We do have a bot since a week 😉

I can set it up if you want - but you can already merge this one I guess.

@fcollonval
Copy link
Member

Release environment set

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
@krassowski krassowski merged commit a7a9f10 into jupyterlab-contrib:master Jul 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants