-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflows, build against JupyterLab 4, fix build TS 5 errors, lint #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update style
Check release is failing because releaser does not know what to do with
|
20 tasks
fcollonval
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @krassowski
we do not have a bot app setup here
We do have a bot since a week 😉
I can set it up if you want - but you can already merge this one I guess.
Release environment set |
fcollonval
reviewed
Jul 15, 2024
fcollonval
reviewed
Jul 15, 2024
fcollonval
reviewed
Jul 15, 2024
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
krassowski
commented
Jul 15, 2024
krassowski
commented
Jul 15, 2024
krassowski
commented
Jul 15, 2024
Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to jupyterlab-contrib/jupyterlab-contrib.github.io#74
master
and using an older version of publishing workflows because I think we do not have a bot app setup here)@ts-ignore
improving compatibility with less common but valid notebooksunknown
)