Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add expand-collapse button #42

Merged
merged 6 commits into from
Mar 25, 2022
Merged

add expand-collapse button #42

merged 6 commits into from
Mar 25, 2022

Conversation

madhur-tandon
Copy link
Member

Closes #27

@madhur-tandon
Copy link
Member Author

Not sure why the test fails, it passes locally for me

fcollonval
fcollonval requested changes Mar 24, 2022
View reviewed changes
src/searchReplace.tsx Outdated Show resolved Hide resolved
src/searchReplace.tsx Outdated Show resolved Hide resolved
fcollonval
fcollonval requested changes Mar 25, 2022
View reviewed changes
ui-tests/tests/search.spec.ts Show resolved Hide resolved
src/searchReplace.tsx Show resolved Hide resolved
fcollonval
fcollonval approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhur-tandon

@fcollonval fcollonval merged commit 0fd9855 into jupyterlab-contrib:master Mar 25, 2022
@madhur-tandon madhur-tandon deleted the expand-collapse branch March 25, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] Expand/collapse all button
2 participants
@madhur-tandon @fcollonval