Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI for replace action #51

Merged
merged 5 commits into from
Apr 7, 2022
Merged

UI for replace action #51

merged 5 commits into from
Apr 7, 2022

Conversation

madhur-tandon
Copy link
Member

Fixes #34

@madhur-tandon
Copy link
Member Author

Playwright Test fails with

File "/.../search-replace/jupyterlab_search_replace/search_engine.py", line 205, in replace
        with open(file_path, "rb") as fp:
    FileNotFoundError: [Errno 2] No such file or directory: '/search-replace-test/conftest.py'

CC: @fcollonval

madhur-tandon and others added 2 commits April 7, 2022 18:37
@madhur-tandon @fcollonval
Update jupyterlab_search_replace/search_engine.py
4a03894 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@madhur-tandon
remove click on search tab
3b8b174
fcollonval
fcollonval approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madhur-tandon

@fcollonval fcollonval merged commit 14abe88 into jupyterlab-contrib:master Apr 7, 2022
@madhur-tandon madhur-tandon deleted the replace-UI branch April 8, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] Add input for replace expression
2 participants
@madhur-tandon @fcollonval