Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Display classes in variables #95

Closed
jtpio opened this issue Oct 24, 2019 · 8 comments
Closed

Display classes in variables #95

jtpio opened this issue Oct 24, 2019 · 8 comments

Comments

@jtpio
Copy link
Member

jtpio commented Oct 24, 2019

For now classes (and potentially other nested data types) don't have their attributes displayed:

image

We'll probably need a few extra calls to variables and send the right variablesReference.

As a reference in VS Code:

image

@KsavinN
Copy link
Collaborator

KsavinN commented Oct 25, 2019

Is this issue related to bad sending request or with backend?

@JohanMabille
Copy link
Member

JohanMabille commented Oct 25, 2019

The backend is really stupid regarding these requests, it forwards the request to the debugger and sends back the reply to the frontend (it is mainly an adapter between DAP protocol and Jupyter protocol ), so I think additional requests should be sent (or the request should be filled with additional parameters) to get all variables.

A mean to get the right parameters is to test with VSCode and ptvsd logs enabled. This way we can inspect all the debug requests received and the reponses and events emitted by PTVSD.

@jtpio
Copy link
Member Author

jtpio commented Oct 25, 2019

Looking at the logs in VS Code, additional variables requests are sent when expanding the a object (screenshot above). But they are not sent initially, only on demand.

@jtpio
Copy link
Member Author

jtpio commented Oct 25, 2019

We can add that to #64

@martinRenou
Copy link
Member

Maybe it would make sense to do this extra request lazily? i.e. only do it if the user clicks on the variable they want to see

@jtpio
Copy link
Member Author

jtpio commented Oct 25, 2019

Maybe it would make sense to do this extra request lazily? i.e. only do it if the user clicks on the variable they want to see

Yes this is what is happening in VS Code (when expanding the object)

@jtpio
Copy link
Member Author

jtpio commented Oct 25, 2019

For reference:

vscode-debug-logs

I will add that to #64

@KsavinN
Copy link
Collaborator

KsavinN commented Nov 15, 2019

was resolve with #125

@KsavinN KsavinN closed this as completed Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants