-
-
Notifications
You must be signed in to change notification settings - Fork 43
Display more variables during expand variable like Class #125
Conversation
Thanks @KsavinN for investigating this. That might look like a workaround but maybe a good compromise for now while we stick to the react-inspector. Will have a look at it locally. |
I get a fork from react-inspector. I will try develop ObjectInspector to make additional props for set |
@jtpio Thanks for catching that. It probably correlated with merge master. I will fix that |
Set breakpoints via the service Convert to source breakpoint in the service Filter breakpoints with the same line numbers Pass this to disconnect Rename onNewCell to onActiveCellChanged Ensure session is ready Use changed signal for models add hover method for breakpoints hover gutter by only css fixed issue with variablesreference 0 and foreach in service Use source path for the breakpoints view Rebase DisplayClassVariable branch
Thanks @KsavinN for the updates, I will have another look at it. |
The last commit changes the behavior slightly, so the As a side-effect, there is a short period of time where we see the previous content, but I think it's fine for now. As a workaround we could check if it's possible to override the empty dict when the node is collapsed. |
Looking at a few other details before merging (switching to wip). |
OK I think we can stop here for now. Thanks again @KsavinN, this is already a good improvement. We can open a new issue with the things to do as follow-up. |
It's not an appropriate method, more like a hack.
ObjectInpsector from react-inspector doesn't have props for handle expand click.
NEW:
![newVar](https://user-images.githubusercontent.com/34033913/68399489-c3be0380-0176-11ea-9630-b20b4fe19276.gif)
OLD:
![](https://user-images.githubusercontent.com/34033913/67797729-955b6c80-fa82-11e9-968b-c2e7bc514c98.gif)