Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Change line highlighting when switching callstack #182

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 14, 2019

Fixes #173.

Leaving the "jump to code" aspect of #173 out of this scope for now (requires adding support for lookup using the hashes first).

switch-callstacks2

TODO

  • Show line highlight for the current selected frame
  • Remove frames from the DebugService class

@jtpio jtpio added this to the 0.1.0 milestone Nov 14, 2019
@jtpio
Copy link
Member Author

jtpio commented Nov 14, 2019

The last commit removes the frames from the DebugService.

This means that scopes are being fetched every time we switch between frames, instead of fetching them all at once:

switch-callstacks3

@jtpio jtpio marked this pull request as ready for review November 14, 2019 11:30
@jtpio
Copy link
Member Author

jtpio commented Nov 14, 2019

Note: the frame on line 2 is related to #144

@jtpio jtpio requested a review from KsavinN November 14, 2019 13:33
@KsavinN
Copy link
Collaborator

KsavinN commented Nov 15, 2019

check locally. It works well

@KsavinN KsavinN merged commit 196d2c9 into jupyterlab:master Nov 15, 2019
@jtpio jtpio deleted the switch-callstack branch November 15, 2019 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch callstack
2 participants