Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Switch to Table View #347

Merged
merged 11 commits into from
Feb 5, 2020
Merged

Switch to Table View #347

merged 11 commits into from
Feb 5, 2020

Conversation

KsavinN
Copy link
Collaborator

@KsavinN KsavinN commented Jan 17, 2020

related with #272

table_tree

@KsavinN KsavinN self-assigned this Jan 17, 2020
@KsavinN KsavinN added the ui label Jan 17, 2020
@KsavinN KsavinN force-pushed the table_view branch 4 times, most recently from f75b0c2 to 37e537d Compare January 17, 2020 14:56
@dhirschfeld
Copy link
Member

Just wondering if the viewer windows shouldn't be ephemeral by default - i.e. after opening a viewer, if the user then clicks on the background the viewer window will disappear (be disposed) automatically. If the user wants the viewer window to remain on top they can pin it by clicking on a "pin" toggle button.

@jtpio
Copy link
Member

jtpio commented Jan 22, 2020

Also wondering how it plays when a new widget (for example another notebook) is open in the main area.

@KsavinN
Copy link
Collaborator Author

KsavinN commented Jan 28, 2020

@jtpio @dhirschfeld What do you think about this, maybe details table should appear as like normal widget in mainArea?
newWay

@dhirschfeld
Copy link
Member

FWIW PyCharm allows you to choose/switch between floating or docked for their widgets which I guess gives the maximum flexibility/configurability. However I think this is pretty good as is - it gives the user the ability to arrange the panels however they want.

@jtpio
Copy link
Member

jtpio commented Jan 29, 2020

This looks good, thanks @KsavinN.

It looks like it feels more natural than the floating windows for now, and more integrated to JupyterLab.

@KsavinN
Copy link
Collaborator Author

KsavinN commented Jan 30, 2020

Hi, I implement our new Tree view and remove React-inspector. This should resolve #177 and #183 .
neewTree

@jtpio
Copy link
Member

jtpio commented Jan 31, 2020

Nice, this has the advantage of being able to fully control click / expand events.

What does it look like with other types of structures, such as classes and numpy arrays?

@KsavinN
Copy link
Collaborator Author

KsavinN commented Jan 31, 2020

Nice, this has the advantage of being able to fully control click / expand events.

What does it look like with other types of structures, such as classes and numpy arrays?

with class:
class

with numpy - it's look like put a lot information from backend:
numpy

@jtpio
Copy link
Member

jtpio commented Jan 31, 2020

Yes for numpy arrays (and potentially more advanced data structures) we should check the variables response to see if it makes sense to keep everything or not.

src/variables/table.tsx Outdated Show resolved Hide resolved
@KsavinN KsavinN marked this pull request as ready for review January 31, 2020 15:26
src/index.ts Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jan 31, 2020

Also we probably want to adjust a couple of CSS variables to support the dark theme:

image

src/index.ts Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/tree.tsx Outdated Show resolved Hide resolved
src/variables/tree.tsx Outdated Show resolved Hide resolved
src/variables/tree.tsx Outdated Show resolved Hide resolved
style/variables.css Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jan 31, 2020

In a next iteration we could try to align the different entries in the tree or add some padding:

image

And make the table columns resizable:

image

But let's track that in different issues.

src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/tree.tsx Outdated Show resolved Hide resolved
src/variables/table.tsx Outdated Show resolved Hide resolved
src/variables/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@KsavinN KsavinN merged commit f268756 into jupyterlab:master Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants