-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ui tests #171
Add ui tests #171
Conversation
Thanks for starting this!
This could be useful to lay the foundations for a potential rework in Galata discussed in jupyterlab/galata#67
Some time a while ago it was also discussed whether to check the screencasts in the repositories because of their size. Probably this will be a similar issue with videos? |
Yes. What I had in mind was to create a manual workflow (or one triggered by new JLab release) that would have open a PR to update those videos/screenshots only once in a while (with maybe a conversion to GIF and cutting the first few seconds corresponding to the logo animation for the videos). |
To many selectors and screenshots are wrong otherwise
Pin playwright
Fix other tests
The failure is on Mac and not related to this. |
Probably this could fix #45? Or do we still want to have examples of setting up unit tests in this repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Also we might want to make the So folks interesting in this could learn how to set them up. This could be in the hello world example, or in a dedicated testing example. |
I would rather create a dedicated example to talk about testing (addressing ui-tests and jest tests). But I want to work on galata to stabilize its usage with playwright before doing so. I'll merge this one and open a PR to add a section about the tests in the README. |
Add playwright to test the examples
This uncovers a bug in style packaging.
This is using playwright test runner (no galata).
There are nice examples of playwright code for:
select
current value (state)log console and alert dialogs are not capture when generating videos from tests. So it seems unappropriate to replace existing preview with those videos although they will allow to be up to date.
What do you think @jtpio @echarles?