Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand wording for has_settings to include mention of schema-defined UI elements #83

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Expand wording for has_settings to include mention of schema-defined UI elements #83

merged 1 commit into from
Jul 15, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski added the enhancement New feature or request label Jul 12, 2024
@gutow
Copy link

gutow commented Jul 12, 2024

+1

@krassowski krassowski marked this pull request as ready for review July 12, 2024 15:49
fcollonval
fcollonval approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@fcollonval fcollonval merged commit 4806a40 into jupyterlab:main Jul 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krassowski @gutow @fcollonval