Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include "keywords" in the hatch-nodejs-version metadata hook plugin configuration #85

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Include "keywords" in the hatch-nodejs-version metadata hook plugin configuration #85

merged 1 commit into from
Jul 23, 2024

Conversation

joaopalmeiro
Copy link
Contributor

Closes #80

With this change, given that the keywords field is dynamic (pyproject.toml), the keywords defined in the package.json file would be considered for the Python package metadata.

@fcollonval fcollonval added the enhancement New feature or request label Jul 23, 2024
fcollonval
fcollonval approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joaopalmeiro

@fcollonval fcollonval merged commit 4ddbfc3 into jupyterlab:main Jul 23, 2024
24 checks passed
@joaopalmeiro joaopalmeiro deleted the fix-missing-keywords branch July 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

keywords defined in the package.json file are not included in the Python package metadata
2 participants
@joaopalmeiro @fcollonval