-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move jupyter-ui-toolkit in the JupyterLab organization #227
Comments
For context, would you mind linking to the meeting notes where this was discussed? Maybe also to the issue or PR that added |
This has been discussed during November 29, 2023 meeting, but there is no mention of the discussion in the notes #205 (comment). The UI-toolkit has been introduced in Jupyterlab in jupyterlab/jupyterlab#15021, and was first admitted in #143. |
For context, the discussion started as an off-shoot of a discussion around a release blocker for 4.1 which is tracked in:
I would appreciate a confirmation on what is the plan to address the above issue before I cast my vote. |
It is worth mentioning that we have been using jupyter-ui-toolkit for quite some time in JupyterLab Desktop as well. |
I'm abstaining from the vote, but want to repeat and reframe my earlier sentiment on moving projects to jupyter organizations: can we please provide more justification behind moving projects than just "we are using this"? It's perfectly fine for jupyter project to use libraries that aren't part of the jupyter organizations. |
I added the following in the top comment:
|
There are a couple of other points that I think would be helpful to understand:
|
The utilities to create custom elements (aka web components) and handle their rendering lifecycle are being updated. But it does not impact consumers of the toolkit. The current status is unfortunately though to provide as the project as be slow since a year.
Fast is an internal dependency of the toolkit. We should not advertise (at least in the short term) the internal tool used by the toolkit. The goal of the toolkit is to provide components on a shell and to consume them either through a framework like React or using vanilla JS. The demo project shows how you can consume the components with vanilla JS or with React. It does not need anything from FAST libraries.
It is; see thoses extensions using the vanilla components or the React variant. It is also used in JupyterLab desktop - to highlight its power to be integrated anywhere in the opposite of React only toolkit.
Not for all things in Jupyter (although it would be for the best). But yes for JupyterLab and yes we (the JupyterLab team) are endorsing it by definition of all projects within this org.
It will surely needs changes when more components are used within core. So not problem with tagging it as WIP. |
As the Jupyter toolkit is now used in JupyterLab, I call for a vote to migrate the repository to the JupyterLab organization following the discussion at the weekly call.
To provide more background, the toolkit is today in the JupyterLab community organization that is not officially endorsed by Jupyter. So moving it in this organization will ensure official support for maintenance and publication rights. In addition it will allow some members to contribute as they may not be allowed to do so on the community organization due to company policy.
@jupyterlab/jupyterlab-council the vote is opened up to December 14th, 2023 (anywhere on earth):
The text was updated successfully, but these errors were encountered: