-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing a toolkit in JupyterLab #143
Comments
Discussion a the weekly meeting:
It's not a given that it would be used for ipywidgets. If that toolkit percolates across different projects, the main benefactors will be JupyterLab/Notebook 7+ and JupyterHub. For ipywidget the first step is likely to make a custom ipywidget library that uses these controls (similar to existing libraries providing material or Vue controls). And them, the question of moving as core replacement may come after experience with that external libraries has been used. As pointed out, one of the challenge of the current widgets are the ability to customize greatly some styling (e.g. the button type).
(definitely lighter than blueprint) The minimified version of the library as standalone library is about 360kB.
Tested installing multiple extensions pinning different version of the toolkit, resulting in only a single version of the library being loaded. All elements were created without errors - the styles were not the latest as the version loaded was an older one (final choice resulted of webpack federation resolution).
It is open source; not open governance (not big or old enough to reach that point).
No, they provide 2 parts:
Concern: is this a library we are confident in depending on. Clarification: it doesn't sound like anyone is against the web components part, it's more important that we find a solution |
A nice side-effect of dropping as much react as possible for the web-components is a probable speed-up gain of the UI; see that benchmark. |
Meeting notes from April 22nd, 2022Attendees: @afshin @ajbozarth @ellisonbg @fcollonval @gabalafou @jasongrout DiscussionThe questions is not on the technology (it sounds mature and well written) but on the additional dependencies and the multiple paradigms to create code for Jupyter frontends:
We are confident that we can support it in the case Microsoft pulls the plug. For example, that repository author recreated template functions and basic class element for creating web-components after trying FAST components library. That part (template generators and web-components registration) is probably the easiest to swap with other libraries. The more complex part is the design system introduced by FAST. A design system is a set of linked variables that will be propagated to the component styles to create a design toolkit.
Probably ok to have different frameworks to coexist with the same application.
ConclusionThe attendees are in favor of adopting of a toolkit based on FAST design for JupyterLab Next stepRequest vote on the JupyterLab Council if there is not enough people at the next JLab meeting (April 27th) to reach consensus. |
Thanks for taking all these notes, @fcollonval! I'm very grateful to have a record of these discussions! |
It was decided at the JupyterLab Weekly meeting to call for a vote on this proposal by @jupyterlab/jupyterlab-council as not enough members were present at Wednesday call. I propose to vote on the first post using the following reaction emojis:
The vote will be closed in a week (aka Thursday May 5th - although May 4th would have been a nice deadline 😄 ) |
Can we paste in the list of Council members with checkboxes so it is clear
who is voting? Also, for those who haven't seen it, here is the decision
making guidelines:
https://github.com/jupyter/governance/blob/master/decision_making.md
…On Wed, Apr 27, 2022 at 11:03 PM Frédéric Collonval < ***@***.***> wrote:
It was decided at the JupyterLab Weekly meeting
<#135 (comment)>
to call for a vote on this proposal by @jupyterlab/jupyterlab-council
<https://github.com/orgs/jupyterlab/teams/jupyterlab-council> as not
enough members were present at Wednesday call.
I propose to vote on the first post using the following reaction emojis:
- 👍 = Agree
- 👎 = Disagree
- 👀 = No opinion
The vote will be closed in a week (aka Thursday May 5th - although May 4th
would have been a nice deadline 😄 )
—
Reply to this email directly, view it on GitHub
<#143 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAGXUCQAZKMTWLOSAPMU6LVHIS2ZANCNFSM5SCUIFGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Brian E. Granger
Senior Principal Technologist, AWS AI/ML ***@***.***)
On Leave - Professor of Physics and Data Science, Cal Poly
@ellisonbg on GitHub
|
This vote has passed with 8 out of 13 members of the JupyterLab Council voting and 100% voting in favor. |
Thanks for opening this discussion and vote @fcollonval! |
Problem
This is a companion PR of the JEP Jupyter UI Components to use a toolkit based on web components for building JupyterLab UI
Proposed Solution
A prototype of the toolkit is implemented using the FAST library by Microsoft.
@jupyterlab/jupyterlab-council votes
Quorum met with
8/13
of @jupyterlab/jupyterlab-council voting.The result was Yes.
8
Yes,0
No,0
AbstainThe text was updated successfully, but these errors were encountered: