Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand off jupyterlab-favorites to jupyterlab team #50

Open
shreddd opened this issue Apr 14, 2020 · 7 comments
Open

Hand off jupyterlab-favorites to jupyterlab team #50

shreddd opened this issue Apr 14, 2020 · 7 comments

Comments

@shreddd
Copy link

shreddd commented Apr 14, 2020

The Jupyterlab Favorites (Add the ability to save favorite folders to JupyterLab for quicker browsing) feature has been tremendously useful, but the summer student who was working on it is no longer with our organization, and we are not ideally suited to supporting this.

Would it be possible to transition this repo/feature:
https://github.com/NERSC/jupyterlab-favorites
to the the Jupyterlab core team?

Note: @jasongrout suggested opening up an issue here

@blink1073
Copy link
Contributor

blink1073 commented Apr 14, 2020

Thanks @shreddd and @tslaton! I am personally in favor, and will bring it up at the team meeting tomorrow.

@blink1073
Copy link
Contributor

From today's meeting we agreed to bring it in as a reposotiry in the org to start. We would iterate and get feedback, and then later bring it in to core. In core, it would be disabled by default but have an easy path to enable it.

@fcollonval
Copy link
Member

@shreddd and @blink1073 as I recently wrote a PR to port that extension in JupyterLab 2, I can work on this.

From that work,

  • [critical] Use state rather than settings to store favorites. The favorites stored in settings will only define the default list.
  • [major] extract dynamic menu from favorite manager
  • [minor][core] create an API to add a button at the end of the breadcumbs (suppress current hack)
  • [minor] add button on each favorite list item to remove them easily
  • [😉] testing

@blink1073
Copy link
Contributor

We had discussion today about how to evolve contributed extensions, documented in #52

@fcollonval
Copy link
Member

@shreddd to move things forward. I happily update and publish it for JLab2 if you grant me the rights on GitHub and NPM; this will avoid creating a fork.

Note my user name is fcollonval on both platforms.

@jtpio
Copy link
Member

jtpio commented Oct 15, 2021

@shreddd just checking: are you still interested in handing off jupyterlab-favorites?

Looks like this could go to the jupyterlab-contrib org which now has quite of a couple of community repos? https://jupyterlab-contrib.github.io/

@fcollonval
Copy link
Member

Small note, it is for now forked in jupyterlab-contrib organization: https://github.com/jupyterlab-contrib/jupyterlab-favorites

But a transfer will be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants