-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] New Github org for JupyterLab satellites #52
Comments
I think we should also encourage people to host their own extensions, rather than this being a dumping ground for every jlab extension. In other words, this new org shouldn't convey any extra assurances to people about the extensions. I think if this new org does end up conveying some special status to people, we've failed in creating a robust extension community outside of JupyterLab proper. I think there is a difference between this and conda-forge, in that conda-forge is very explicitly just a packaging org, as opposed to underlying package development in conda-forge. Also, conda-forge admins do explicitly help maintain all conda-forge packages (for example, mass migrations to new python versions or compiler versions). Are we volunteering to help shepherd packages to, say, jlab 2.0? When would people create an extension here, as opposed to just hosting the extension in their own personal org or creating a new org? |
I believe just for visibility and as a way to reduce duplicate efforts. A single namespace can help with that, even by itself, without any guarantees of support. I agree we would do less than conda forge does to keep things going, I think at most just being able to step in and add new people as maintainers if old people step away and new ones come. |
Please do not feel a need to comment on jupyterlab-lsp itself, just bringing my thoughts to you for an early feedback from the community side! |
To clarify (and push back a bit to make sure we are addressing the underlying issues):
I think my biggest concern is that this adds to our maintenance burden (managing an org), and it implicitly gives a stamp of approval on some community extensions, but not others. Can we satisfy this need for publicity without having to consolidate development to a GitHub org? For example, a webpage that lists JupyterLab extensions (beyond the extension manager in jlab)? If someone wants to move a project out of their personal github, creating a new github org is cheap. If someone is looking to pass on the project to others, instead of pushing that responsibility onto us in a contrib org, perhaps they should create an org and nominate others, or we should celebrate that OSS allows people to fork and carry on? Also if people are putting the projects there for others to take up, then it may turn out to be mostly a graveyard with an occasional exception. |
@jcb91, @juhasch, @jfbercher - you have arguably the most successful contrib repo for Jupyter, the https://github.com/ipython-contrib/jupyter_contrib_nbextensions repo. What are your thoughts about having an org for third-party unofficial JupyterLab extensions? How much time does it take (has it taken) for you? |
The Jupyter incubator is explicitly about projects that are being considered for adoption as official Jupyter projects, IIRC. This would be for community projects with a much lower bar. |
@jasongrout That list looks good. Probably not jupyterlab-celltags though, since that one was actually pulled into core. I'm not actually sure what we should do with the repo at https://github.com/jupyterlab/jupyterlab-celltags, which is badly out of date by now. It doesn't seem like great practice to just leave it lying around |
Oh right. We can archive it, like we did for https://github.com/jupyterlab/jupyterlab-statusbar |
Thanks for the feedback @krassowski! I think it would be fine to have multiple related repos together in this org. We don't necessarily want an explosion of orgs, that would make it hard to find things. |
jupyterlab-pygments is a dependency of two core projects (nbconvert and Voilà). I think it belongs to core. |
Note: anything marked as core will also need to be added to the release process for JupyterLab. |
Basically we'll need to have integration checks for things like |
Ideally we'd have e2e checks in CI for that as well. |
There is a case to be made for taking |
All there is in jupyterlab-pygments is a list of colors for pygments: What would you environ as a test for that? Should we check that the variables still exist in JupyterLab's CSS? |
A notebook that runs and produces DOM nodes that we can inspect properties of. |
This may be a test for nbconvert I guess, but JupyterLab-pygments is merely a pygments style using JupyterLab's CSS variables. (The ones used in the custom codemirror theme). |
I mean running the notebook in the browser |
We need more of that, in general. |
For instance, our release checklist has us manually running this notebook and making sure it works. |
Ah gotcha. Should I render some code with Pygments (and that style) inline in a notebook? |
Yeah, you can either keep in in the pygments repo and we can target it, or put it here. |
If what is being proposed here is to have If something else is being proposed, could you please clarify... My personal preference, and mostly for visibility and community building, would be to avoid fragmentation and maybe move things that are not being updated to some sort of If we need to distinguish between core committers and extension committers, we can still handle that with one org using teams. |
OK, I will add it first to the jupyterlab_pygments repository. It will be a nice example actually. |
Hi @lresende, thanks for pushing back!
It might contain server extensions, lsp providers, or something else entirely
Teams are only really visible internally, and even then I get confused as to who is on what team. Having a separate org makes it much more explicit. |
I added a test notebook and a screencast in the readme. Note that jupyterlab_pygments is a dependency of nbconvert 6.0 (which is in pre-release at the moment) so I think it should remain in a Jupyter org. |
I just created jupyterlab-contrib organization in the hope to initiate a similar dynamic than jupyter_contrib_nbextensions for JupyterLab. Happy to discuss governance and to add volunteers that want to help in it.
|
Any trademark or logo questions should be addressed to the trademark committee: https://jupyter.org/governance/trademarks.html |
Thanks Jason for the quick answer. The request has been submitted. |
Thanks @fcollonval for starting this 👍 Wondering whether the organization should maybe mention the word "community" as an alternative to "unofficial"? Something like "JupyterLab Community Extensions & Tools". |
Is this new org being part of Jupyter and following Jupyter governance? |
Yeah, if one of the requirements is adheres (and links to) the Jupyter Code of Conduct, "community" feels nicer. And while a moon is, indeed, technically a satellite of a planyt, a nice line art icon of a human-made satellite would have a lot of punch... cubesats have totally changed the education/execution of space missions in the last 10 years, we might want to harken a bit to that. |
If this would be an "officially accepted Jupyter org" where all projects are official Jupyter projects, then I would not oppose it, but if we really think about it, the proliferation of multiple org will make what in the past was a cohesive community, to become fragmented into multiple locations which will make sub-projects apart of each other with time. |
Thanks all for your contributions. As nicely summarized by Jason in that comment, there are many questions arisen by this; especially regarding maintenance burden, organization management and level of trust user will have. As I'm not involved in the Jupyter governance and after looking closely on the jupyter_contrib_nbextensions repository strategy, I decided to mimic it. So for now I use the term unofficial to clearly state it is not officially accepted by the Jupyter.org and it should not be more trusted than any code one may find out on the internet. And therefore I did not enforce the Jupyter Code of Conduct. To answer more specifically the comments made:
I did not use the word community and prefer unofficial to not give a false sense of trust.
For now no. But I would love to have it accept it (note: I don't know what it is needed)
Great idea thanks for it
That is a risk indeed; especially as the Jupyter ecosystem is already composed of many organizations. |
Alright. I guess it makes sense and closely mimic the It might just be a personal preference, but the word Also as a reference, other ecosystems use this term even if the projects they host are unofficial. For example |
Closing as fixed by #126 |
In today's team meeting, we discussed the evolution of "core" repositories.
We decided that we needed a new org to meet the following goals
We notionally agreed to call this org
jupyterlab-forge
, as a nod to our friends atconda-forge
.The
jupyterlab
org would remain focused on JupyterLab itself and things that it depend on that we maintain, such asjupyterlab_server
, and theapod
example.We should deprecate the
jupyter-renderers
and split it up into different repos on this new org.Ideally, we should have a cookie cutter for new repos in this org and a guide to use them
The text was updated successfully, but these errors were encountered: