Bind reject method to promise, improve typing

jupyterlab · Aug 12, 2024 · 6995078 · 6995078
1 parent 4351ad9
commit 6995078
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/jupyter-ai/src/completions/handler.ts b/packages/jupyter-ai/src/completions/handler.ts
@@ -110,7 +110,7 @@ export class CompletionWebsocketHandler implements IDisposable {
     (value: AiService.InlineCompletionReply) => void
   > = {};
 
-  private _onClose(e: CloseEvent, reject: any) {
+  private _onClose(e: CloseEvent, reject: (reason: unknown) => void) {
     reject(new Error('Inline completion websocket disconnected'));
     console.error('Inline completion websocket disconnected');
     // only attempt re-connect if there was an abnormal closure
@@ -137,7 +137,7 @@ export class CompletionWebsocketHandler implements IDisposable {
       (token ? `?token=${encodeURIComponent(token)}` : '');
 
     const socket = (this._socket = new WebSocket(url));
-    socket.onclose = e => this._onClose(e, promise.reject);
+    socket.onclose = e => this._onClose(e, promise.reject.bind(promise));
     socket.onerror = e => promise.reject(e);
     socket.onmessage = msg => msg.data && this._onMessage(JSON.parse(msg.data));
   }