Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For /ask queries, chat history is not bounded #224

Closed
3coins opened this issue Jun 16, 2023 · 0 comments · Fixed by #240
Closed

For /ask queries, chat history is not bounded #224

3coins opened this issue Jun 16, 2023 · 0 comments · Fixed by #240
Assignees
@3coins
Labels
bug Something isn't working
Milestone
0.9.0 Release

Comments

@3coins
Copy link
Collaborator

3coins commented Jun 16, 2023

Description

Chat history object in current /ask queries is appended endlessly, which can end up exceeding the token limits on most LLM providers.

Solution

Truncate the chat history to last 2 conversations, this is sufficient buffer for maintaining context between previous conversations.
@3coins 3coins added the bug Something isn't working label Jun 16, 2023
@3coins 3coins added this to the 0.9.0 Release milestone Jun 16, 2023
@3coins 3coins self-assigned this Jun 16, 2023
@3coins 3coins mentioned this issue Jun 16, 2023
Merged
@3coins 3coins mentioned this issue Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3coins 3coins

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0 Release
Development

Successfully merging a pull request may close this issue.

Truncate chat history to last 2 conversations 3coins/jupyter-ai
2 participants
@3coins @dlqqq