Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncate chat history to last 2 conversations #240

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Truncate chat history to last 2 conversations #240

merged 5 commits into from
Jun 27, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Jun 23, 2023

Fixes #224

@3coins 3coins added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jun 23, 2023
@3coins 3coins added this to the 0.9.0 Release milestone Jun 23, 2023
@3coins 3coins self-assigned this Jun 23, 2023
@3coins 3coins marked this pull request as ready for review June 23, 2023 21:16
dlqqq
dlqqq reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a section to the documentation to make this behavior explicit?

@3coins 3coins requested a review from dlqqq June 24, 2023 00:05
@3coins @JasonWeill
Update docs/source/users/index.md
630955f 
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
@3coins @JasonWeill
Update packages/jupyter-ai/jupyter_ai/actors/ask.py
bc920fb 
Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
@3coins 3coins merged commit 42c6d43 into jupyterlab:main Jun 27, 2023
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@3coins @JasonWeill
Truncate chat history to last 2 conversations (jupyterlab#240)
c24b2f6 
* Truncate chat history to last 2 conversations

* Updated docs for conversation history

* Updated headings for images

* Update docs/source/users/index.md

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/jupyter-ai/jupyter_ai/actors/ask.py

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

---------

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@3coins @JasonWeill @Marchlak
Truncate chat history to last 2 conversations (jupyterlab#240)
f05e310 
* Truncate chat history to last 2 conversations

* Updated docs for conversation history

* Updated headings for images

* Update docs/source/users/index.md

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

* Update packages/jupyter-ai/jupyter_ai/actors/ask.py

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>

---------

Co-authored-by: Jason Weill <93281816+JasonWeill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonWeill JasonWeill JasonWeill approved these changes

@dlqqq dlqqq Awaiting requested review from dlqqq

Assignees

@3coins 3coins

Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0 Release
Development

Successfully merging this pull request may close these issues.

For /ask queries, chat history is not bounded
3 participants
@3coins @dlqqq @JasonWeill