Migrate streaming logic to BaseChatHandler
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2024
|
Hello, good afternoon. I would like to be unsuscribed from this group,
please. I am receiving too many emails every day. Please.
Kind regards,
Christopher Anich.
…On Fri 18 Oct 2024, 23:49 david qiu, ***@***.***> wrote:
Description
- Migrates streaming logic from DefaultChatHandler to BaseChatHandler,
"lifting up" the implementation such that it can be re-used by different
child classes.
- This will allow for streaming support in other slash commands we
provide, e.g. /ask and /fix.
- This will also allow developers using custom slash commands to
re-use our streaming logic, which will stay updated when jupyter_ai is
upgraded.
- The new "stop streaming" feature introduced by #1022
<#1022> required
changes to the streaming logic, meaning that this feature will not work for
existing custom slash commands that implement streaming. Developers will
have to manually intervene if they want their slash commands to be
stoppable after upgrading to v2.26.0.
- This change will prevent this scenario from happening again in
the future.
------------------------------
You can view, comment on, or merge this pull request online at:
#1039
Commit Summary
- 7107bfe
<7107bfe>
migrate streaming logic to `BaseChatHandler`
- f533e7f
<f533e7f>
add ignore comments to resolve `mypy` errors
- 388b0bb
<388b0bb>
pre-commit
- 2b1083b
<2b1083b>
revert change to LLMChain import module
File Changes
(4 files <https://github.com/jupyterlab/jupyter-ai/pull/1039/files>)
- *M* packages/jupyter-ai/jupyter_ai/chat_handlers/ask.py
<https://github.com/jupyterlab/jupyter-ai/pull/1039/files#diff-6e09b53257fc99bac8b132e61531175e798c65fd107844c4d21c4754b2bb71ae>
(6)
- *M* packages/jupyter-ai/jupyter_ai/chat_handlers/base.py
<https://github.com/jupyterlab/jupyter-ai/pull/1039/files#diff-e164ea9ccdd1b4c56ee5e6cdf7d4bc838cccd88f7fdb7f447332a21565d2803f>
(143)
- *M* packages/jupyter-ai/jupyter_ai/chat_handlers/default.py
<https://github.com/jupyterlab/jupyter-ai/pull/1039/files#diff-61b6ffc90741cf3d7ba3038ef6a0ea0d28645adf64ce247a4420f711048dde2d>
(118)
- *M* packages/jupyter-ai/jupyter_ai/chat_handlers/fix.py
<https://github.com/jupyterlab/jupyter-ai/pull/1039/files#diff-e97a377cfc1eba64e747e0ec74570ac8eb952599b5a9d7020de57b089c661026>
(10)
Patch Links:
- https://github.com/jupyterlab/jupyter-ai/pull/1039.patch
- https://github.com/jupyterlab/jupyter-ai/pull/1039.diff
—
Reply to this email directly, view it on GitHub
<#1039>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A77O7PTALUJVJ5RPYPZE6YDZ4GF6VAVCNFSM6AAAAABQG2KEQKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TQNJRGI3TMNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
krassowski
reviewed
Oct 21, 2024
| stream_id: str, | ||
| content: str, | ||
| complete: bool = False, | ||
| metadata: Dict[str, Any] = {}, |
There was a problem hiding this comment.
Just highlighting a pre-existing potential issue here (https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil)
There was a problem hiding this comment.
Thanks for calling this out! I'll update the code & keep this mind in the future.
It would be better if there was some automated method of catching this for other devs. Do you know of any linter that can flag mutable default arguments?
dlqqq
force-pushed
the
lift-streaming-logic
branch
from
2b1083b
to
dff511e
Compare
srdas
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
I tested this PR. Code seems good as well, the transfer from default.py to base.py is useful and a good refactor for future development.
- Standard streaming response works as expected.
- Streaming with
@filealso works as expected. - Streaming with
/askand/fixnot implemented and is unaffected. Placeholder for these with runnable are appropriately placed in the code.
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* migrate streaming logic to `BaseChatHandler` * add ignore comments to resolve `mypy` errors * pre-commit * revert change to LLMChain import module * drop mutable default argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DefaultChatHandlertoBaseChatHandler, "lifting up" the implementation such that it can be re-used by different child classes./askand/fix.jupyter_aiis upgraded.Follow-up issues
Issues that should be addressed after this PR is merged & released (in descending priority).
/ask#863/fix#1041